fix: don't use polynomial rings over zero rings #1684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1684 +/- ##
==========================================
- Coverage 76.01% 76.00% -0.01%
==========================================
Files 362 362
Lines 114299 114306 +7
==========================================
- Hits 86882 86880 -2
- Misses 27417 27426 +9
|
lgoettgens
reviewed
Nov 15, 2024
src/NumField/NfAbs/Elem.jl
Outdated
Comment on lines
160
to
161
| Main.a = a | ||
| Main.n = n |
There was a problem hiding this comment.
Just a reminder to remove these debugging artifacts again once you are finished tracking down all uses of zero rings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.